[bitnami/rabbitmq] Fix NetworkPolicy to include extraContainerPorts in ingress rule
Fix to extraContainerPorts not being pulled in from values file
Signed-off-by: Chris Ritchie [email protected]
Description of the change
Currently any extraContainerPorts configured within the values.yaml file are ignored and fail to be added to the networkingpolicy.yaml file.
For example, without this fix the following config in the values.yaml file is ignored:
extraContainerPorts:
- name: stomp-ws
containerPort: 15674
- name: stomp-tcp
containerPort: 61613
Benefits
stomp-tcp & stomp-ws ports can be exposed using an ingress.
Possible drawbacks
Applicable issues
- fixes #25426
Additional information
This did work at some point in the past (~2021), and the extraContainerPorts config in the values.yaml file still exists. As this used to work at some point in the past I consider this a bug rather than an enhancement.
Checklist
- [X] Chart version bumped in
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files. - [X] Variables are documented in the values.yaml and added to the
README.mdusing readme-generator-for-helm - [X] Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
- [X] All commits signed off and in agreement of Developer Certificate of Origin (DCO)
Thanks @migruiz4 for your review. I have updated the PR as requested. Is there anything else I need to do?
Hi @migruiz4, code review changes implemented and conflicts resolved. Thanks
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.