[bitnami/redis] persistence.labels are ignored

[monotek]

Name and Version

bitnami/redis

What architecture are you using?

amd64

What steps will reproduce the bug?

helm template bitnami/redis --set master.persistence.labels.foo=bar

Are you using any custom parameters or values?

See above.

Value should be the right one. See: https://github.com/bitnami/charts/blob/main/bitnami/redis/templates/replicas/application.yaml#L538C93-L538C118

What is the expected behavior?

Label should be added to pvc:

  volumeClaimTemplates:
    - apiVersion: v1
      kind: PersistentVolumeClaim
      metadata:
        name: redis-data
        labels:
          app.kubernetes.io/instance: release-name
          app.kubernetes.io/name: redis
          app.kubernetes.io/component: replica
          foo: bar
      spec:
        accessModes:
          - "ReadWriteOnce"
        resources:
          requests:
            storage: "8Gi"

What do you see instead?

only the default labels are added:

  volumeClaimTemplates:
    - apiVersion: v1
      kind: PersistentVolumeClaim
      metadata:
        name: redis-data
        labels:
          app.kubernetes.io/instance: release-name
          app.kubernetes.io/name: redis
          app.kubernetes.io/component: replica
      spec:
        accessModes:
          - "ReadWriteOnce"
        resources:
          requests:
            storage: "8Gi"

Additional information

Same happens if you use sentinel.

[javsalgar]

Hi!

Thank you so much for reporting. Indeed, it seems that there's a missing reference to the persistence labels in the volumeClaimTemplates. As you discovered the issue, would you like to submit a PR?

[fullykubed]

Just wanted to add that this impacts replica as well.

[github-actions[bot]]

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

[github-actions[bot]]

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.