[bitnami/mlflow] added support for google storage
Description of the change
This adds a section to the MLFlow template to configure Google Cloud Storage, and changes to the deployment template to make it support GCS. -- A user has two options: To use a secret for storing their application credentials, or to not configure application credentials; and use workload identity.
Benefits
This adds support for natively storing artifacts with Google Cloud Storage. It is a feature that MLflow supports but didn't have a way to configure.
Possible drawbacks
None really; more configuration? -- I do see that; had GCS support been envisioned from day one configuration may have been structured slightly different.
Applicable issues
- fixes #22720
- Depends on: https://github.com/bitnami/containers/pull/67246
Additional information
Things to double check:
- [x] do any init container scripts need to be modified? -- mostly they are related to minio
- [x] is there additional documentation needed anywhere?
Checklist
- [x] Chart version bumped in
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files. - [x] Variables are documented in the values.yaml and added to the
README.mdusing readme-generator-for-helm - [x] Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
- [x] All commits signed off and in agreement of Developer Certificate of Origin (DCO)
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.
Ah; I just noticed that the changes to the Docker Image supposedly have been released!
See: https://github.com/bitnami/containers/pull/67246
I will test this shortly and update this PR to make it merge-able when I can confirm everything works.
Ah; I just noticed that the changes to the Docker Image supposedly have been released!
I will test this shortly and update this PR to make it merge-able when I can confirm everything works.
Thanks for this MR @dhrp. We are using some custom stuff to support the gcs(passing args to containers for example), but would like to use this instead . If any more work/testing is to be done or pending, i would be willing to contribute.
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.
Hello,
I'm currently looking for support of GCS in this Helm Chart and I think this PR is exactly what I'm looking for (especially now that the Docker image include google-storage). However this PR seems inactive... What is the best way to contribute / reopen it @jotamartos? I can reopen another MR with @dhrp changes and reviewing your comments if it's ok for you?
Thanks,
Yes, feel free to open a new PR. You can start from this point, using the @dhrp changes, we will be happy to review it and provide feedback. Here you can find the contributing guidelines.