charts icon indicating copy to clipboard operation
charts copied to clipboard

[bitnami/kube-prometheus] Add a prometheus.extraEnvVars

Open maggie44 opened this issue 1 year ago • 6 comments

Name and Version

kube-prometheus

What is the problem this feature will solve?

There appears to be an extraEnvVars option of all of the components of the kube-prometheus chart except the main Prometheus pod itself (prometheus-prometheus-kube-prometheus-prometheus-0).

https://github.com/bitnami/charts/tree/c81241d87d534bf986d52934c80b65f846be0632/bitnami/kube-prometheus

What is the feature you are proposing to solve the problem?

This is the pod that uses most memory, and I would like to be able to configure the Golang runtime variables. Namely, I am looking to set gogc to 60 through the environment variable.

What alternatives have you considered?

Can't think of any.

maggie44 avatar May 26 '24 16:05 maggie44

Hi!

Thank you so much for the feature request. I will forward it to the team, but as it is not a critical feature, we cannot guarantee an ETA. However, if you want to speed up the process, you can contribute with a PR and the team will check it.

javsalgar avatar May 27 '24 11:05 javsalgar

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

github-actions[bot] avatar Jun 12 '24 01:06 github-actions[bot]

Still active

maggie44 avatar Jun 12 '24 05:06 maggie44

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

github-actions[bot] avatar Jun 28 '24 01:06 github-actions[bot]

Bit aggressive time frame for marking items stale that have been accepted as valid feature requests.

maggie44 avatar Jun 28 '24 06:06 maggie44

Thank you for bringing this issue to our attention. We appreciate your involvement! If you're interested in contributing a solution, we welcome you to create a pull request. The Bitnami team is excited to review your submission and offer feedback. You can find the contributing guidelines here.

Your contribution will greatly benefit the community. Feel free to reach out if you have any questions or need assistance.

carrodher avatar Jun 28 '24 08:06 carrodher

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

github-actions[bot] avatar Jul 04 '24 01:07 github-actions[bot]

5 days now? I think it’s best just to let this close, it’s not practical to keep promoting to reopen it.

maggie44 avatar Jul 04 '24 06:07 maggie44

Bumping here as this need has occurred again on another cluster. OOM killer kicking in and the best option for us to utilise the available golang features rather than scale the memory allowance unnecessarily.

Something similar found here: https://github.com/bitnami/charts/issues/25555 https://prometheus.io/docs/prometheus/latest/feature_flags/#auto-gomemlimit

maggie44 avatar Sep 19 '24 06:09 maggie44

Bumping here as this need has occurred again on another cluster. OOM killer kicking in and the best option for us to utilise the available golang features rather than scale the memory allowance unnecessarily.

Something similar found here: #25555 https://prometheus.io/docs/prometheus/latest/feature_flags/#auto-gomemlimit

I'm thinking prometheus.enableFeatures may help me here for enabling the new flag Prometheus has added: https://prometheus.io/docs/prometheus/latest/feature_flags/#auto-gomemlimit

maggie44 avatar Sep 19 '24 07:09 maggie44

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

github-actions[bot] avatar Oct 05 '24 01:10 github-actions[bot]

Bumping here as this need has occurred again on another cluster. OOM killer kicking in and the best option for us to utilise the available golang features rather than scale the memory allowance unnecessarily. Something similar found here: #25555 https://prometheus.io/docs/prometheus/latest/feature_flags/#auto-gomemlimit

I'm thinking prometheus.enableFeatures may help me here for enabling the new flag Prometheus has added: https://prometheus.io/docs/prometheus/latest/feature_flags/#auto-gomemlimit

This did solve my problem. Would still be nice to be able to add my own custom env vars, but for this particular need of GOMEMLIMIT the auto gomemlimit in Prometheus turned out to be a better solution.

Happy to keep this one closed.

maggie44 avatar Oct 05 '24 06:10 maggie44