charts icon indicating copy to clipboard operation
charts copied to clipboard

[bitnami/mariadb] PVCs labels not rendered

Open csandanov opened this issue 10 months ago • 2 comments

PVCs labels rendered incorrectly

  • [x] Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • [ ] Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • [ ] Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • [ ] All commits signed off and in agreement of Developer Certificate of Origin (DCO)

csandanov avatar Apr 24 '24 17:04 csandanov

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

github-actions[bot] avatar May 11 '24 01:05 github-actions[bot]

Hi, thank you for proposing this change in the bitnami/mariadb chart. However, I don't really see the reason for the change. Can you describe the issue you are trying to fix? Using common.labels.matchLabels is a common pattern we use in several charts. Is there any problem with that?

In addition to that, I'm unable to render the helm templates after applying your changes:

$ helm template . -s templates/primary/statefulset.yaml | grep -A20 volumeClaimTemplates
Error: YAML parse error on mariadb/templates/primary/statefulset.yaml: error converting YAML to JSON: yaml: line 200: mapping values are not allowed in this context

andresbono avatar May 13 '24 06:05 andresbono

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

github-actions[bot] avatar May 19 '24 01:05 github-actions[bot]