charts icon indicating copy to clipboard operation
charts copied to clipboard

[bitnami/postgresql-ha] Fix issue where user password is not set when a different username is provided

Open migruiz4 opened this issue 1 year ago • 2 comments

Description of the change

Fixes an issue where env variable POSTGRES_POSTGRES_PASSWORD was not being when global.posgresql.username/posgresql.username is set to a value different than postgres.

Although key postgresql-password is being automatically generated in the Secret, the password will never be set unless value posgresql.postgresPassword/global.posgresql.postgresPassword.

This PR makes it possible for users to use postgresql-ha chart where postgres user uses a random password.

Possible drawbacks

I'm not sure if this behavior was intentional, to force users to provide a password for user postgres and avoid risks of users losing the root user password on restarts.

Applicable issues

  • fixes #24226

Checklist

  • [X] Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • [X] Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • [X] Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • [X] All commits signed off and in agreement of Developer Certificate of Origin (DCO)

migruiz4 avatar Mar 21 '24 08:03 migruiz4

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

github-actions[bot] avatar Apr 20 '24 01:04 github-actions[bot]

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

github-actions[bot] avatar Apr 30 '24 01:04 github-actions[bot]

can we please get this merged? Theres like 3 issues which seem to be a subsequent downstream issue of this.

8ball030 avatar May 19 '24 15:05 8ball030

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

github-actions[bot] avatar Jun 04 '24 01:06 github-actions[bot]

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

github-actions[bot] avatar Jun 10 '24 01:06 github-actions[bot]

Probably solved at https://github.com/bitnami/charts/pull/27095

carrodher avatar Jun 19 '24 06:06 carrodher