charts icon indicating copy to clipboard operation
charts copied to clipboard

[bitnami/mlflow] allowed minAvailable to be percentage

Open dhrp opened this issue 2 years ago • 1 comments

Description of the change

This fixes a simple issue in the validation / values.schema.json whereby the pod disruption budget minAvailable replicas is not allowed to be presented in percentages.

It also updates the schema to the latest values.yaml, as the history shows that one fix (S3 credentials optional) was applied to the schema, but other changes are lacking behind the values.yaml. This PR pulls it up to current.

The image and repository also changed to default values; but from what I understand this is supposed to happen.

Benefits

Allows PDB minAvailable replicas is not allowed to be presented in percentages.

Possible drawbacks

This should work as is.

Applicable issues

  • Does not have a matching Issue number

Additional information

I checked a few things about this with @antaloala

Checklist

  • [x] Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
    • Does this apply to values.schema.json?
  • [x] Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • [x] Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • [x] All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Thatcher Peskens [email protected]

dhrp avatar Feb 15 '24 18:02 dhrp

Thank you for initiating this pull request. We appreciate your effort. Just a friendly reminder that it's important to sign your commits. Adding your signature certifies that you either authored the patch or have the necessary rights to contribute the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Apart from that, please note it's needed to bump the chart version in the Chart.yaml file.

Feel free to reach out if you have any questions or need assistance with the signing process.

carrodher avatar Feb 15 '24 20:02 carrodher