charts icon indicating copy to clipboard operation
charts copied to clipboard

[bitnami/prestashop] feat: :sparkles: :lock: Add resource preset support

Open javsalgar opened this issue 1 year ago • 0 comments

Signed-off-by: Javier Salmeron Garcia [email protected]

Description of the change

This PR adds support for resourcesPreset in the chart and normalizes the use of the resources object. Now users will be able to test the different resource presets defined in the bitnami/common chart in PR https://github.com/bitnami/charts/pull/23410.

In addition to this, it adds a warning in NOTES.txt case users are not setting the resources value, as this is a bad practice and potential security vulnerability. The resourcesPreset values are meant to help the user define their own resources section but it is not recommended in production.

Benefits

Users become more aware of the importance of the resources values. Users can use the presets for their own testing.

Possible drawbacks

Potentially annoying for users that were not setting the resources section.

Checklist

  • [x] Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • [x] Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • [x] Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • [x] All commits signed off and in agreement of Developer Certificate of Origin (DCO)

javsalgar avatar Feb 14 '24 14:02 javsalgar