charts icon indicating copy to clipboard operation
charts copied to clipboard

[bitnami/thanos] Sync prometheus alerting rules with upstream

Open antonblr opened this issue 1 year ago • 2 comments

Description of the change

Inspired by prometheus-community/kube-prometheus-stack/hack.

This change adds a script to sync-up Thanos chart prometheus alerting rules with upstream https://github.com/thanos-io/thanos/tree/main/mixin library and updates existing rules with the generated ones.

In particular the sync resulted in the following changes:

  • Removed ThanosReceiveTrafficBelowThreshold (see #5824)
  • Added ThanosReceiveLimitsConfigReloadFailure (see #6466
  • Added ThanosReceiveLimitsHighMetaMonitoringQueriesFailureRate (see #6466)
  • Added ThanosReceiveTenantLimitedByHeadSeries (see #6467)

The remaining diff are mostly formatting changes.

Benefits

Automatically generates up to date rules.

Possible drawbacks

Some python knowledge may be needed in order to add new functionality to the script and / or update the existing one.

Applicable issues

N/A

Additional information

Checklist

  • [x] Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • [x] Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • [x] Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • [x] All commits signed off and in agreement of Developer Certificate of Origin (DCO)

antonblr avatar Feb 09 '24 18:02 antonblr

Resolved conflicts due to changes in https://github.com/bitnami/charts/pull/22687/files

antonblr avatar Feb 15 '24 00:02 antonblr

Sorry for the inconvenience, there was a new minor version of this chart that requires a rebase from main and a new bump of the version

carrodher avatar Feb 20 '24 12:02 carrodher

Hi @carrodher, should we sync-up somehow on when you're ready to merge it (if there is no outstanding questions/concerns) and I'll do the final bump in the Chrat.yaml. Otherwise I feel like in a never ending race 😄 due to continuous changes in it. Thank you!

antonblr avatar Feb 22 '24 19:02 antonblr