charts icon indicating copy to clipboard operation
charts copied to clipboard

Allow setting loadBalancerClass on service configurations

Open oliver-ni opened this issue 3 years ago • 3 comments

Name and Version

lots; example: bitnami/mongodb 13.1.5

What is the problem this feature will solve?

If you run multiple LoadBalancer controller implementations in a single cluster, there is currently no way to configure services created by bitnami Helm charts to use specific implementations.

What is the feature you are proposing to solve the problem?

The spec.loadBalancerClass lets you specify which implementation to use. I am proposing to add a field similar to service.loadBalancerIPs called service.loadBalancerClass that is forwarded into the service configuration.

What alternatives have you considered?

No response

oliver-ni avatar Sep 20 '22 20:09 oliver-ni

Hi!

Thank you so much for the feature request! Would you like to submit a PR with the new feature?

javsalgar avatar Sep 21 '22 08:09 javsalgar

I can work on one, yes. However, I haven’t worked on any Helm charts before. Please let me know if there are any caveats I should watch out for with this feature

oliver-ni avatar Sep 21 '22 08:09 oliver-ni

It is adding a non-breaking feature, so you should ensure that the values is only added to the YAML when set. Apart from that, I don't see many issues. Make sure you read the development guidelines in the repo. Thank you so much!

javsalgar avatar Sep 21 '22 09:09 javsalgar

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

bitnami-bot avatar Oct 07 '22 01:10 bitnami-bot

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

github-actions[bot] avatar Oct 12 '22 01:10 github-actions[bot]

This is not solved

oliver-ni avatar Oct 12 '22 05:10 oliver-ni

Reopened as the PR is still open

javsalgar avatar Oct 12 '22 08:10 javsalgar