sealed-secrets icon indicating copy to clipboard operation
sealed-secrets copied to clipboard

Allow add annotations/labels on private key creation/rotation

Open vhsantos opened this issue 2 years ago • 2 comments

Which component: controller

Is your feature request related to a problem? Please describe.

Actually, the private key creation/rotation function does not allow us to include any kind of annotations/labels to it.

Which should be useful to replicate theses secrets automatically to another(s) cluster(s) using systems like "kubed/config-syncer", which check for an specific annotations on the secrets/configmaps to be replicate.

Describe the solution you'd like

private key creation/rotation should accept a list of annotations/labels from the controller configuration.

--privatekey-annotations 'kubed.appscode.com/sync: ""'
--privatekey-labels 'app.kubernetes.io/instance=production-cluster' --privatekey-labels 'app.kubernetes.io/part-of=sysadmin'

Additional context Replicate secrets between clusters using [kubed/config-syncer](https://github.com/kubeops/config-syncer)

Note: Not sure if someone have this kind of tasks (replicate the private key between cluster) covered using another solution ?

vhsantos avatar Sep 08 '22 10:09 vhsantos

Hi @vhsantos this is an interesting proposal. Would you like to send a PR with the implementation?

agarcia-oss avatar Sep 15 '22 07:09 agarcia-oss

Hello @agarcia-oss , I would love it, but my knowledge about go language is very basic (shame on myself). :-(

vhsantos avatar Sep 15 '22 08:09 vhsantos