sealed-secrets icon indicating copy to clipboard operation
sealed-secrets copied to clipboard

Label "app.kubernetes.io/instance" in the condition_info Prometheus metric

Open tewfik-ghariani opened this issue 6 months ago • 4 comments

Description of the change

A new label called ss_app_kubernetes_io_instance is added to the sealed_secrets_controller_condition_info Prometheus metric

This label shows the app.kubernetes.io/instance label value of the SealedSecret resource itself, if it exists

e.g

apiVersion: bitnami.com/v1alpha1
kind: SealedSecret
metadata:
  labels:
    app.kubernetes.io/instance: grafana-qa

Here is an example of the newly added metric label: Screenshot 2024-08-14 at 15 53 43

I checked the /metrics endpoint and the metric label is considered empty if it did not exist, thus it is not breaking anything

Benefits

The scraped information of the Sealed Secret resources include an indicator of the instance name / release name associated to that specific resource

Users relying on Grafana may conduct more complex queries to join and map the instance name with other queries

Possible drawbacks

None

Applicable issues

None

Additional information The usage of the app.kubernetes.io/instance label is the standard as it is part of the k8s recommended labels: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

tewfik-ghariani avatar Aug 14 '24 14:08 tewfik-ghariani