sealed-secrets
sealed-secrets copied to clipboard
`commonAnnotations` are not implemented for all resources
The documentation for the commonAnnotations value says "Annotations to add to all deployed resources":
https://github.com/bitnami-labs/sealed-secrets/blob/5b0c26ea09fb2a32634eb1c935c5c28e3a44914c/helm/sealed-secrets/values.yaml#L19
Yet, not all resources have annotations at all, let alone the common annotations:
https://github.com/bitnami-labs/sealed-secrets/blob/5b0c26ea09fb2a32634eb1c935c5c28e3a44914c/helm/sealed-secrets/templates/cluster-role-binding.yaml#L4-L9
I suggest we implement commonAnnotations to work as documented. Depending on the circumstances, it might be good to implement it via a template in _helpers.tpl and reference that instead.