bitmovin-player-react-native icon indicating copy to clipboard operation
bitmovin-player-react-native copied to clipboard

Published 20 hours ago • verified publisher icon bitmovin

Exception are now always caught, remove compile time check

Open krocard opened this issue 7 months ago • 0 comments

Problem (PRN-92)

RejectPromiseOnExceptionBlock was introduced as a compile time way of throwing with a guaranty that the exception would be caught and the promise rejected.

Now that all the code has been migrated to the safer run*AndRejectOnException, the complexity of RejectPromiseOnExceptionBlock is no longer warrantied.

Changes

Remove RejectPromiseOnExceptionBlock, which allows some simplification as it was shadowing the receiver in some cases.

📚 Other PRs for this issue

  • 📗 bitmovin/bitmovin-player-react-native#317
  • 📖 bitmovin/bitmovin-player-react-native#345
  • 📙 bitmovin/bitmovin-player-react-native#346
  • 📒 bitmovin/bitmovin-player-react-native#347
  • 📜 bitmovin/bitmovin-player-react-native#343

krocard avatar Dec 05 '23 16:12 krocard