bitmaelum-suite icon indicating copy to clipboard operation
bitmaelum-suite copied to clipboard

Cleanup code smells from sonarcloud

Open jaytaph opened this issue 4 years ago • 4 comments

Take some time to do a cleanup of the code smells as found in sonarcloud:

https://sonarcloud.io/project/issues?id=bitmaelum_bitmaelum-suite&resolved=false

jaytaph avatar Dec 06 '20 14:12 jaytaph

Hi, this project looks interesting, I'm eager to contribute.

This issue presents itself as a nice starting point into your codebase, mind if take it?

GreenStage avatar Jan 23 '21 12:01 GreenStage

welcome! We're always happy to have new people contribute. You're more than welcome to pick up issues. The code might be a little hard to grasp maybe because there is a lot going on, but most of the sonarcloud issues are doable enough.

jaytaph avatar Jan 23 '21 12:01 jaytaph

https://github.com/bitmaelum/bitmaelum-suite/pull/171

GreenStage avatar Jan 23 '21 16:01 GreenStage

image

Pretty nice work done! We got rid of half the code smell issues

I leave this issue open for now, so we can tackle the rest later

jaytaph avatar Jan 24 '21 10:01 jaytaph