data_hacks icon indicating copy to clipboard operation
data_hacks copied to clipboard

Python 3 compatibility?

Open sursh opened this issue 8 years ago • 8 comments

Hi folks. Planning Python 3 compatibility for this awesome tool? I'm getting SyntaxErrors, looks like from print statements missing parens.

<3

sursh avatar Oct 14 '15 04:10 sursh

@sursh python3 compatibility would be awesome. Any interest in submitting some pull requests for the incompatibilities you uncovered?

jehiah avatar Oct 14 '15 13:10 jehiah

No, can't help out, my plate is a bit full right now.

On Oct 14, 2015, at 9:40 AM, Jehiah Czebotar [email protected] wrote:

@sursh python3 compatibility would be awesome. Any interest in submitting some pull requests for the incompatibilities you uncovered?

— Reply to this email directly or view it on GitHub.

sursh avatar Oct 14 '15 14:10 sursh

unfortunately i know that state all too well. Thanks for getting this issue started though!

jehiah avatar Oct 14 '15 14:10 jehiah

I think I can take care of that! The plan would be to run python-modernize, which is a program that makes programs compatible for 2.6 - the 3s, and then clear up any additional errors that pop up when I run it in Python 3. I've done that for bar_chart.py, and can push it your way to see if that's what you'd like for the rest of them. Also let me know if you have any bundles of tests that are good to run to more concretely make sure everything is still working properly.

Shadhopson avatar Oct 15 '15 23:10 Shadhopson

@Shadhopson still up for this?

sursh avatar Jul 15 '16 15:07 sursh

oh hey, look at #35. Just needs to be merged in.

sursh avatar Jul 15 '16 16:07 sursh

@jehiah - I realize this is ~3 years old but python3 native would be great if you can spare some time.

I applied #35 and found that it is working as expected with python 3.7.3 (tested data_hacks/histogram.py). Good job @melor !

graysky2 avatar May 11 '19 12:05 graysky2

Just to give an update in 2020, right now I found two ways to install data_hacks with Python 3 compatibility:

  1. Install @nicholasren's fork: pip install data_hacks3
  2. Install @melor's fork: pip install -e git://github.com/melor/data_hacks.git@py3#egg=data_hacks

harrybiddle avatar Nov 25 '20 09:11 harrybiddle