wip icon indicating copy to clipboard operation
wip copied to clipboard

Does not work with GPG commiting turned on

Open Alxandr opened this issue 9 years ago • 3 comments

Any chance you think you can get wip to work with GPG committing turned on?

Alxandr avatar Apr 20 '16 18:04 Alxandr

Hey @Alxandr – I'd love to implement it. Would you mind spec-ing out how that should work? Would it be another setting? Should the WIP commits be signed?

Could you put together a sample list of git commands wip/naenae should run through to accommodate? Thanks!

bitjson avatar Apr 20 '16 20:04 bitjson

It's not a config (though, it could be), but rather dealing with different output from git commands. As an example, look at the following:

image

If I run wip, the following happens:

image

Alxandr avatar Apr 21 '16 10:04 Alxandr

Ah, that makes sense. If you're interested in working on it, I'd love to take a pull request.

I think it might be wise to develop tests for Travis CI to run before implementing – it looks like that would require at least minor modifications to most of the code base (moving from simple execution/output to streaming input/output). Definitely would be valuable, though.

I wrote tests for the s18n CLI this weekend, and I think it would be very similar. I'll probably take a shot at implementing tests when I have some time in the next few weeks. (Though if you could submit a pull request for this feature, I would definitely prioritize it to pull in your changes!)

bitjson avatar Apr 25 '16 14:04 bitjson