companion icon indicating copy to clipboard operation
companion copied to clipboard

[BUG] Generic midi + Collection issue

Open Gopala27 opened this issue 2 months ago • 6 comments

Make sure you're on the latest stable or beta build

  • [x] I have tested this on the latest stable or beta release

Is this a bug in companion itself or a module?

  • [x] I believe this to be a bug in companion and not a specific module

Is there an existing issue for this?

  • [x] I have searched the existing issues

Describe the bug

I create several triggers grouped in a collection. Each triggers are waiting for received a Program Change midi message and then activate a macro in my Atem mini. When the collection as well as the triggers are activated, it seems that the macro are run sometime one time, sometime 2 times (or maybe +).

If I deactivate the collection but keep the triggers activated, it seems to work correctly.

Steps To Reproduce

  1. Create a collection and keep it activated Image

  2. Create trigger with generic midi, waiting for program change to run a macro in atem

Image Image Image
  1. Send Midi command => sometime the macro works, sometime the macro is activated several times

  2. Deactivate the collection

Image
  1. Send the midi command => macro is activated only one time

Expected Behavior

Macri should be run one time

Environment (please complete the following information)

- OS: WIndows 10
- Browser: Chrome
- Companion Version: 4.1.1

Additional context

No response

Gopala27 avatar Oct 10 '25 12:10 Gopala27

You should move this to the generic-midi module "issues" page.

MeestorX avatar Oct 11 '25 05:10 MeestorX

Hi @MeestorX, I'm sorry, it was my first post here. But I think the issue is related to collection and not midi.

Gopala27 avatar Oct 12 '25 15:10 Gopala27

I dont think I entirely follow what you are saying here.

Is this just the one trigger firing multiple times, or multiple triggers being fired?

  1. Send the midi command => macro is activated only one time

Are you saying that the triggers inside the collection are firing when when the collection is disabled?
Because that should not be happening (and is not for me)

Julusian avatar Oct 19 '25 14:10 Julusian

Hi @Julusian, what I observed is that when Collection + triggers are activated, one trigger firing multiple times. And yes, when the collection is disabled but triggers activated, the trigger is firing correctly. I forgot to mention that I'm using PC A to send the midi request to PC B via RTPMIDI. Companion is launched on PC B. I will try the same test but launching Companion on PC A.

Gopala27 avatar Oct 20 '25 08:10 Gopala27

Are you still able to reproduce this? I have been unable to get a trigger to fire while its collection is disabled, and have not seen any double firing

Julusian avatar Nov 27 '25 22:11 Julusian

I will work on this topic this week-end and I will let you know

Envoyé à partir de Outlook pour Androidhttps://aka.ms/AAb9ysg


From: Julian Waller @.> Sent: Thursday, November 27, 2025 11:01:20 PM To: bitfocus/companion @.> Cc: Gopala27 @.>; Author @.> Subject: Re: [bitfocus/companion] [BUG] Generic midi + Collection issue (Issue #3696)

[https://avatars.githubusercontent.com/u/1327476?s=20&v=4]Julusian left a comment (bitfocus/companion#3696)https://github.com/bitfocus/companion/issues/3696#issuecomment-3587376094

Are you still able to reproduce this? I have been unable to get a trigger to fire while its collection is disabled, and have not seen any double firing

— Reply to this email directly, view it on GitHubhttps://github.com/bitfocus/companion/issues/3696#issuecomment-3587376094, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BEORT6SR6KAIZ5P6QURLV3D365YDBAVCNFSM6AAAAACI2VVHO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKOBXGM3TMMBZGQ. You are receiving this because you authored the thread.Message ID: @.***>

Gopala27 avatar Nov 28 '25 07:11 Gopala27