companion icon indicating copy to clipboard operation
companion copied to clipboard

[BUG] Grid Size minimum and maximum wording confusing

Open ckohen opened this issue 1 year ago • 0 comments

Is this a bug in companion itself or a module?

  • [X] I believe this to be a bug in companion

Is there an existing issue for this?

  • [X] I have searched the existing issues

Describe the bug

As a developer, the grid sizing makes sense to me since I'm used to 0 indexing, however even for me there is a couple of wording errors that are confusing.

This makes sense as is however it would be clearer with number added to the end maybe? e.g. Minimum Row Number image

The grid size here is as expected, however the minimum and maximum are extremely confusing. Maybe something more like Row 0, Column 0, and Row 1, Column 2 would be better. image

I'm sure there are people way better at writing docs than me that can come up with a better way to describe this for non-devs

Steps To Reproduce

  1. Go to Settings
  2. Scroll to button grid
  3. Change settings in grid size and observe behavior

Expected Behavior

I expect the settings to be self-describing in such a way that I can hand companion to someone who is tech savvy but not dev oriented and they will understand them.

Environment (please complete the following information)

- OS: MacOS Monterey
- Browser: Chromium 127.0.2651.74
- Companion Version: companion-pi 3.4.0

Additional context

No response

ckohen avatar Sep 24 '24 01:09 ckohen