bitfocus
[BUG] Intermittent crash / Streamdeck disconnect on 3.3
Is this a bug in companion itself or a module?
- [X] I believe this to be a bug in companion
Is there an existing issue for this?
- [X] I have searched the existing issues
Describe the bug
Having an intermittent issue with 3.3 where Companion will crash and then redraw all buttons on all stream decks.
In the logs, it seems to correlate with a Streamdeck disconnecting as well. The stream deck isn't being disconnected physically, so this might just be part of the crash?
This is the error thrown:
2024-02-0616:33:26.833Z error Surface/Handler/streamdeck:(serial) Elgato Streamdeck XL disconnected
libc++abi: terminating due to uncaught exception of type std::_ 1:: system_error: thread:: join failed: No such process
2024-02-06116:33:26.867Z Application: Companion exited with code: null
2024-02-06116:33:26.867Z Application: Restart Count: 1
2024-02-0616:33:28.413Z
info Log/Controller Application
This started happening randomly, and then occurred every couple minutes until I restarted the whole app.
Upon restart, I was also getting some errors on the Connections page. These eventually went away with a re-load:
Steps To Reproduce
No response
Expected Behavior
No response
Environment (please complete the following information)
- OS: macOS 13.6.4
- Browser: Firefox
- Companion Version: 3.3.0 (3.3.0+6715-main-9ab80ab0)
Additional context
No response
I think I have identified the cause of this and pushed a fix.
Let me know how you get on, or if you can still reproduce the crash. I haven't looked at the ui errors yet
Thanks for looking into it! I will update and let you know if it occurs again, although I haven't had the issue in a couple days so might not be super apparent.
@Julusian Not sure if this is the same bug, but I experienced some more weird behavior with a stream deck re-drawing intermittently today. It's totally possible it's just a wonky deck,
but it was solid for the past week after the update until today. Here's what it's saying in the log: