companion
companion copied to clipboard
[BUG] "Y" / "Z" keyboard shortcuts mixup on QUERTZ keyboard (e.g. german) with emulator
Is this a bug in companion itself or a module?
- [X] I believe this to be a bug in companion
Is there an existing issue for this?
- [X] I have searched the existing issues
Describe the bug
when running emulator on a machine with QWERTZ keyboard layout (e.g. german), the keyboard shortcut for bottom left most button should by "Y" but is "Z".
Steps To Reproduce
- run companion on a machine with QWERTZ keyboard layout
- open emulator
- select first-column buttons (1,q,a,y) --> all but "Y" work, bottom-left most button is actually invoked by "Z"
Expected Behavior
first column buttons should be controlled by first row of keys (1 and below)
Environment (please complete the following information)
- OS: MacOS Monterey
- Browser: Chrome
- Companion Version: 2.2.0 (2.2.0+3998-ccea40c7)
Additional context
this could be done by determining the respective keyboard layout, which could be tricky to do at high compatibility, or simply provide a parameter that one can choose to set the layout.
this issue will likely be even more extreme in other language layouts that have more differences to the english keyboard setup)
Some libraries such as https://github.com/nrkno/sorensen can handle the variation of keyboard layout for us, and let us instead target certain positions in the keyboard. It might result in lacking support for older browsers, but that might not be an issue