gs1js icon indicating copy to clipboard operation
gs1js copied to clipboard

AIs with more than 2 digits not working

Open csaar95 opened this issue 4 years ago • 6 comments

The parsing of following code 241ABC1234<FNC1>100815 results in:

 [{
   "identifier": "24",
   "value": "1ABC1234",
   "length": 8
 }, {
   "identifier": "10",
   "value": "0815",
   "length": 4
 }]

The AI 24 doesn't exist (https://www.gs1.org/standards/barcodes/application-identifiers), the correct result would've been identifier "241" and value "ABC1234".

Unortunately in this case the module is absolutely useless:/

csaar95 avatar Oct 13 '21 17:10 csaar95

PRs welcome. This is open source ;-)

bitflower avatar Oct 13 '21 20:10 bitflower

Hello Matthias, after reading over ur code, I decided to solve it in a fresh piece of code. I didn't see a possibility fixing the "design mistake" to only react on two digit AIs without rewriting mostly of the code. I finished the parser today, and we'll probably publish it in the next time. I'll link it here! Hopefully u'll don't take my criticism the wrong way.

csaar95 avatar Oct 14 '21 20:10 csaar95

@csaar95 did you ever get to finish your code?

Remo avatar May 03 '22 14:05 Remo

@Remo It is, but I didnt publish it yet, are you interested?

csaar95 avatar May 03 '22 14:05 csaar95

@csaar95 well, I am looking for a gs1 parser, so yes 😉

Remo avatar May 03 '22 14:05 Remo

@csaar95 I'm also really interested in a working parser 😄

AlexandreKueny avatar Jun 27 '23 14:06 AlexandreKueny