blackwater icon indicating copy to clipboard operation
blackwater copied to clipboard

Korma queries don't log passed parameters

Open zerokarmaleft opened this issue 11 years ago • 3 comments

I have a patch in progress (zerokarmaleft/blackwater@48a3ff50358ca6ec7409991a658398b9f082451b), but I figured I'd bounce the idea off of you first to see if you had a preference for a different approach. Changing the arity of log-sql breaks the jdbc module obviously, but it doesn't look like the jdbc hooks are adding passed parameters to the log output either.

zerokarmaleft avatar Dec 24 '13 17:12 zerokarmaleft

:+1: I'm using this patch in my fork and left the existing arity in place for the jdbc consumer (trptcolin/blackwater@a069a534afe1ed9c70bfddcae1a03a2580af5cb7). I'm assuming there's some real solution for jdbc, but I don't have the time/interest at the moment to dig in further. Would be nice to have this on the official repo so I can use it instead of my clojars release.

trptcolin avatar Mar 20 '14 14:03 trptcolin

@bitemyapp please, import @trptcolin 's solution - works for me, thanks!

razum2um avatar Aug 24 '14 11:08 razum2um

@razum2um

I'll merge a PR that has working code for both JDBC and Korma.

bitemyapp avatar Aug 24 '14 19:08 bitemyapp