coinselect icon indicating copy to clipboard operation
coinselect copied to clipboard

Include type definitions in the package

Open gabmontes opened this issue 1 month ago • 1 comments

Types were added in #77 but not included in the NPM package, therefore type checking cannot be properly done. This is the error usually thrown by TypeScript:

Could not find a declaration file for module 'coinselect'. '.../node_modules/coinselect/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/coinselect` if it exists or add a new declaration (.d.ts) file containing `declare module 'coinselect';`

Including the type definitions file in the package as done in https://github.com/ChrisCho-H/bitcoinselect/commit/f173732264232749e4343e21769b8c4a084d38a7 and publishing a new version will solve the problem.

Note that I didn't bump the package version in this PR but happy to do so if that would help.

Possibly related to #85 too.

gabmontes avatar Dec 02 '25 14:12 gabmontes

any chance to publish an new version ?

aaronisme avatar Dec 03 '25 06:12 aaronisme

@gabmontes can you pls pour fresh master into your branch? im hoping it will fix all failing CI jobs

Overtorment avatar Dec 15 '25 10:12 Overtorment