bitcoinjs-lib
bitcoinjs-lib copied to clipboard
Published
20 hours ago •
bitcoinjs
bitcoinjs
TODO: BIP174 should not have TransactionInput/Output
trafficstars
Bring over TransactionInput from BIP174 to here. Remove from BIP174.
Done. See PRs:
-
https://github.com/bitcoinjs/bitcoinjs-lib/pull/1655
-
https://github.com/bitcoinjs/bip174/pull/26
-
TransactionInputAdder&TransactionOutputAdderhave not been moved since they were not used
Travis build fails due to tiny-secp256k1 error (not related with these changes):
> [email protected] install /home/travis/build/bitcoinjs/bitcoinjs-lib/node_modules/tiny-secp256k1
219> node-gyp rebuild
220
221make: Entering directory '/home/travis/build/bitcoinjs/bitcoinjs-lib/node_modules/tiny-secp256k1/build'
222 CXX(target) Release/obj.target/secp256k1/native/addon.o
223../native/addon.cpp: In function ‘Nan::NAN_METHOD_RETURN_TYPE ecdsaVerify(Nan::NAN_METHOD_ARGS_TYPE)’:
224../native/addon.cpp:320:58: error: no matching function for call to ‘v8::Value::BooleanValue(v8::Local<v8::Context>)’