bech32 icon indicating copy to clipboard operation
bech32 copied to clipboard

feat: add hybrid cjs-esm support

Open Nesopie opened this issue 1 year ago • 3 comments

  • We discussed this in the stream but are you happy with the way tests are being done right now? Currently they're being run from the source itself. This prevents build files from getting into the bundle but I can revert to testing both of them individually as well.

  • TODO: Have to change the other commands as well apart from build and test

Nesopie avatar Apr 12 '24 16:04 Nesopie

I've tested out the other commands and they work fine too, @junderw can you have a look?

Nesopie avatar Apr 16 '24 13:04 Nesopie

Could you convert the existing travis CI config to Github Actions CI so I can run the tests and lints on this? Thanks.

junderw avatar Apr 17 '24 12:04 junderw

Hey! The devDependency I used to run ts files, i.e. tsx is not supported on lower versions of node so tests start failing on those versions (passes on lts) in the CI.

I've tried instead to run tests on two different builds without tsx but that requires you to change the way imports are done on both the files (which can't be done as they're built from the same source so you can't get two different outputs).

One suggestion would be to just test on one build and stick with that, however I'd like your opinion on this before I move ahead

Nesopie avatar Apr 18 '24 02:04 Nesopie

Testing one build should be fine

junderw avatar May 20 '24 14:05 junderw