bitcoinj icon indicating copy to clipboard operation
bitcoinj copied to clipboard
verified publisher icon bitcoinj

ByteUtils: remove unused helpers

Open schildbach opened this issue 3 years ago • 5 comments

I take it we agrred to not have unused read/write helpers. So this PR removes the currently unused.

schildbach avatar Mar 23 '23 23:03 schildbach

I've milestoned this to 0.17 as a reminder to go through all the read and write helpers and remove those that are unused.

schildbach avatar Mar 27 '23 10:03 schildbach

I take it we agrred to not have unused read/write helpers. So this PR removes the currently unused.

I find that which ones were are using keeps changing. So it might make sense to wait till all the refactoring is finished before removing them.

msgilligan avatar Mar 27 '23 12:03 msgilligan

I take it we agrred to not have unused read/write helpers. So this PR removes the currently unused.

I find that which ones were are using keeps changing. So it might make sense to wait till all the refactoring is finished before removing them.

msgilligan avatar Mar 27 '23 12:03 msgilligan

Rebased. I think the refactoring is finished, so we can probably merge this?

schildbach avatar Sep 30 '23 16:09 schildbach

I think I have some unfinished refactoring that might change which ones we need. If you don't mind waiting until a little closer to release, I would prefer that.

msgilligan avatar Sep 30 '23 17:09 msgilligan

Rebased. Ready to merge?

schildbach avatar Apr 27 '24 18:04 schildbach

Merged.

schildbach avatar Apr 27 '24 21:04 schildbach