bitcoinj icon indicating copy to clipboard operation
bitcoinj copied to clipboard

Refactor UTXOTest.java and add two new test methods to it

Open MethDamon opened this issue 5 years ago • 2 comments

Changes:

  • Split multiple asserts into test methods
  • Added test method for getIndex()
  • Added test method for getHash()

Also, this test uses the normal java serialization rather than writeObject() and readObject(), is this done willingly or by mistake?

MethDamon avatar Apr 24 '19 10:04 MethDamon

@schildbach Can you take another look at this?

MethDamon avatar May 09 '19 09:05 MethDamon

I think this is very similar to #1813. Splitting the test into many "micro tests" imho doesn't scale.

I see however a couple of new asserts ~~"hidden" in your refactoring~~. If you think they're worth to have, we could add them.

schildbach avatar May 11 '19 16:05 schildbach