bitcoindevkit.org icon indicating copy to clipboard operation
bitcoindevkit.org copied to clipboard

docs/bdk-cli/installation.md:allow for individual copy/paste

Open RandyMcMillan opened this issue 1 year ago • 7 comments

RandyMcMillan avatar Jul 05 '24 16:07 RandyMcMillan

Deploy Preview for awesome-golick-685c88 ready!

Name Link
Latest commit c56e219ead24d29ecfd289def496a745a4b48e04
Latest deploy log https://app.netlify.com/sites/awesome-golick-685c88/deploys/66886220c5b9b4000882614d
Deploy Preview https://deploy-preview-186--awesome-golick-685c88.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 05 '24 16:07 netlify[bot]

this change allows each command to be copied individually.

https://deploy-preview-186--awesome-golick-685c88.netlify.app/bdk-cli/installation/

Screenshot 2024-07-05 at 12 06 07 PM

RandyMcMillan avatar Jul 05 '24 16:07 RandyMcMillan

Concept ACK. We'll be going through all docs once bdk-1.0.0 makes it to first beta release. This is a good thing to keep in mind for any docs where you don't want to run all the commands.

notmandatory avatar Jul 05 '24 21:07 notmandatory

i will leave this open - rebase as neccesary.

RandyMcMillan avatar Jul 06 '24 11:07 RandyMcMillan

taking a look at 'key' custom signet support and help output. Add a -n signet --challenge support?

RandyMcMillan avatar Jul 06 '24 11:07 RandyMcMillan

bdk-cli AFAIK only output valid keys for global signet currently.

RandyMcMillan avatar Jul 06 '24 11:07 RandyMcMillan

custom signet support ought to be on the v1 roadmap (non blocking but a nice to have)

RandyMcMillan avatar Jul 06 '24 11:07 RandyMcMillan

@RandyMcMillan for some reason I can never rebase/force push on your branches I'm not sure why.

This is my error:

bitcoindevkit.org on  2021/850814/700297/f65aedb30/b21e96f20-docs/bdk-cli/installation.md [$] is 📦 v1.0.0 via  v21.7.3
❯ git push --force
fatal: The upstream branch of your current branch does not match
the name of your current branch.  To push to the upstream branch
on the remote, use

    git push upstream HEAD:refs/pull/186/head

To push to the branch of the same name on the remote, use

    git push upstream HEAD

To choose either option permanently, see push.default in 'git help config'.

To avoid automatically configuring upstream branches when their name
doesn't match the local branch, see option 'simple' of branch.autoSetupMerge
in 'git help config'.

I tried both options above and they both don't work.

I'm not 100% sure this would fix our issue, but would you mind opening PRs that use branches with more standard names, say in this case docs/cli-fix?

In any case I just opened a new PR with this commit. #200

thunderbiscuit avatar Oct 28 '24 13:10 thunderbiscuit

Merged.

thunderbiscuit avatar Oct 28 '24 13:10 thunderbiscuit