bdk icon indicating copy to clipboard operation
bdk copied to clipboard

Improving the documentation for TxBuilder

Open prakharjain-slice opened this issue 2 years ago • 4 comments
trafficstars

Describe the enhancement
Documentation regarding absolute fee and fee rate is little unclear in BDK docs. Common concerns are:

  • Is absolute fee in sats or btc?
  • If we add both absolute fee and fee rate while building the transaction which will be honoured?

Use case
This documentation will help users in better understanding of Tx object and can optimise their transaction fees.

prakharjain-slice avatar Feb 09 '23 13:02 prakharjain-slice

See also discussion in #823

notmandatory avatar Mar 02 '23 16:03 notmandatory

Can someone please review this #957

roy9495 avatar Apr 29 '23 06:04 roy9495

Is it appropriate to close this issue as IMO all of its tasks are completed.

15IITian avatar Feb 26 '24 15:02 15IITian

https://github.com/bitcoindevkit/bdk/pull/1159 still needs to be merged, but CI is broken

danielabrozzoni avatar Feb 26 '24 18:02 danielabrozzoni