bdk icon indicating copy to clipboard operation
bdk copied to clipboard

Implement `Deref<Target=Client>` for `ElectrumBlockchain`

Open afilini opened this issue 2 years ago • 1 comments

Description

As pointed out in https://github.com/bitcoindevkit/rust-electrum-client/pull/58#issuecomment-1207890096 there was no way to keep using the client once it was given to BDK.

Checklists

All Submissions:

  • [x] I've signed all my commits
  • [x] I followed the contribution guidelines
  • [x] I ran cargo fmt and cargo clippy before committing

afilini avatar Aug 08 '22 10:08 afilini

Thank you for having a look at this! Could you also add the same for EsploraClient?

tnull avatar Aug 08 '22 11:08 tnull

@afilini #722 implements this for our Esplora clients. I just created it in case this is needed urgently. This will change a bit once we refactor our Esplorablockchain code to incoroporate our new rust-esplora-client

vladimirfomene avatar Aug 15 '22 14:08 vladimirfomene

@afilini #720 implements this for our Esplora clients. I just created it in case this is needed urgently. This will change a bit once we refactor our Esplorablockchain code to incoroporate our new rust-esplora-client

Thanks for having a look a this! @afilini also created a BDK branch that makes use of the updated external rust-esplora-client (https://github.com/afilini/bdk/tree/feat/use-external-esplora-client), which implements this. I'm currently tracking this branch for my development.

tnull avatar Aug 15 '22 14:08 tnull