bdk
bdk copied to clipboard
bitcoindevkit
Document MSRV policy and change MSRV to 1.49.0
Description
Set MSRV policy to be at most Debian "testing" release version of rustc. Update build-test CI job matrix to use the current latest stable version and MSRV ~~1.56.0~~ 1.49.0.
Fixes #331 Fixes #496
Notes to the reviewers
Fixes CI error caused by tokio MSRV changing to 1.49.0, see #522.
I also changed from a fixed stable version (was 1.56.0) to the latest stable because we haven't been updating it manually and this will ensure we're always testing against current stable rust.
Checklists
All Submissions:
- [x] I've signed all my commits
- [x] I followed the contribution guidelines
- [x] I ran
cargo fmtandcargo clippybefore committing
Prior to merging I also need to change the required github checks to ~~1.56.0~~ 1.49.0 and stable.
I would avoid bumping the MSRV unless we get stuck or have issues somewhere. Maybe our policy could be "at most" debian testing, meaning that we will never go above, but we'll still try to support older versions if we can
I should have linked to the PR that triggered this PR: https://github.com/bitcoindevkit/bdk/pull/522#issuecomment-1042393238
Maybe we don't need to bump the MSRV all the way to 1.56.0, I'll see if we can get away with rust 1.48.0
As mentioned by @moneyball on Discord, the LDK team pinned their tokio version to ~1.14 instead of increasing their MSRV, see https://github.com/lightningdevkit/rust-lightning/pull/1315. I believe one downside of this approach is we won't be getting new tokio fixes or features unless that team plans to back port them to 1.14.x releases.
Note that tokio does backport fixes, so I'm not sure how much of a concern it is in practice. As for MSRV of 1.49, that seems exceedingly recent - notably most linux distros still ship 1.41 (and rustup is rather unacceptable for anything security-conscious, like Bitcoin).
@TheBlueMatt, good points. I created https://github.com/bitcoindevkit/bdk/pull/550 as a fix to get our CI working and then we can take our time to decide about any MSRV changes.
I like and support this change. We recently upgraded all our other stuff to tokio 1.17 and it worked well with bdk up to 0.16. Now I tried upgrading bdk to 0.17 and got conflicts. With this change in place, we could upgrade to a newer bdk, without having to downgrade tokio.
Another transitive dependency, http, has now updated their MSRV to 1.49, see #595.
Note that even if a dep updates their MSRV you can keep the looser bound on the MSRV and users can pin-back with something like cargo update -p tokio --precise "1.14.1", which works to make the ldk-sample build with 1.41 even though by default it will try to build with a newer tokio.
Note that even if a dep updates their MSRV you can keep the looser bound on the MSRV and users can pin-back with something like
cargo update -p tokio --precise "1.14.1", which works to make the ldk-sample build with 1.41 even though by default it will try to build with a newer tokio.
That does seem like a clean way to do it, but if we used this approach would I also need to add that command to my CI pipeline matrix for testing with 1.46? If so I think it's easier to pin it in the Cargo.toml for now.
Yes, you'd have to do that in CI as well. I suppose it'd be one thing if it were a truly ancient rustc, but 1.41 is still the version shipped on many distros, so its kinda hard to demand that for every user :/
Hey, we are in the process of releasing BDK 1.0, which will under the hood work quite differently from the current BDK. For this reason, I'm closing all the PRs that don't really apply anymore. If you think this is a mistake, feel free to rebase on master and re-open!
