Variable block confirmation for confirmed balances

[matthiasdebernardini]

Describe the enhancement

Allow wallet.balance().confirmed to be configurable based on how many blocks it should consider it to be confirmed, 1 by default then 3 or 6. Not sure what else could be useful.

Use case

Wallets designed for large balances should prefer to have this set to a high number, 6 for example.

Additional context

Got posted in bdk_wallet first, @evanlinjin noted that this can be achieved via wallet.local_chain().tip() https://github.com/bitcoindevkit/bdk_wallet/issues/210

[rustaceanrob]

1 doesn't feel like a great default to me. Reorgs of depth one happen all the time. I would go with 3, which to my knowledge has never occured, and then leave 1, 3, 6 as options.

[matthiasdebernardini]

I agree. If confirmed means finalfinal or not subject to change, then yeah it should be 3 and not 1. Though it should be optional.

[uvuvuwu]

Can I take this?

[LagginTimes]

Hi @uvuvuwu! Just checking in to see if this is still being actively worked on — or if there’s anything we can do to help move it forward. Let us know if you're still interested or if you’ve run into any blockers.

[uvuvuwu]

Hi @LagginTimes . Sorry I am no longer able to work on this actively. Please feel free to take over.

[LagginTimes]

Closed with #2007.