feat(chain,wallet)!: rm `ConfirmationTime`

[evanlinjin]

Description

This PR removes ConfirmationTime, and favors ChainPosition<ConfirmationBlockTime> instead. The only difference between these two structures is that ChainPosition<ConfirmationBlockTime> contains an additional BlockHash. Additionally, ConfirmationTime was not used in many places. It was mainly for displaying information in bdk_wallet::Wallet.

We also impl serde::Deserialize and serde::Serialize for ChainPosition.

Notes to the reviewers

Changelog notice

• Remove bdk_chain::ConfirmationTime. Use ChainPosition<ConfirmationBlockTime> in place.

Checklists

All Submissions:

• [x] I've signed all my commits
• [x] I followed the contribution guidelines
• [x] I ran cargo fmt and cargo clippy before committing

[LagginTimes]

ACK a3d4eef77d427b290e1d0041d3c760b8fe29f6a2

[notmandatory]

@evanlinjin should we add this to the 1.0-beta milestone? It's a breaking change but looks straight forward and has two ACKs.

[evanlinjin]

@notmandatory I agree. I think this makes sense to be part of 1.0-beta.