bdk icon indicating copy to clipboard operation
bdk copied to clipboard

refactor: replace `get_address` & `get_balance` to `address` & `balance` resp

Open 15IITian opened this issue 1 year ago • 4 comments

Description

Rename the get_address to address & get_balance to balance -> and make subsequent changes in the codebase.

Notes to the reviewers

This is done in order to make methods names according with rust API naming guidelines

Checklists

All Submissions:

Bugfixes:

  • [x] This pull request breaks the existing API
  • [x] I'm linking the issue being fixed by this PR

Fix #1221

15IITian avatar Mar 06 '24 10:03 15IITian

@15IITian are you applying for the summer of bitcoin program? If so I recommend less focus on trivial issues like this one that do not demonstrate any knowledge of bitcoin or rust skills. Otherwise these PRs are fine for just getting some practice with basic rust and the github PR review process.

notmandatory avatar Mar 07 '24 18:03 notmandatory

@15IITian are you applying for the summer of bitcoin program?

Yes

I recommend less focus on trivial issues like this one that do not demonstrate any knowledge of bitcoin or rust skills.

Noted and thanks for it.

15IITian avatar Mar 08 '24 04:03 15IITian

You should follow the PR template that should have been added to this PR automatically. In particular it helps reviewers to see a summary description of exactly what you're changing.

Also rather than just putting the issue # that is being fixed if you say "fixes #<PR number>" then github will automatically link the issue to the PR.

notmandatory avatar Mar 16 '24 02:03 notmandatory

This is a small change but I think we should push it to the 2.0 milestone.

notmandatory avatar Mar 20 '24 03:03 notmandatory

Closing since this address changes were fixed by #1402 and the can be fixed in another PR.

notmandatory avatar Jun 01 '24 22:06 notmandatory