bdk icon indicating copy to clipboard operation
bdk copied to clipboard

fix!(chain): Make spk revelation return owned spks

Open LLFourn opened this issue 1 year ago • 3 comments

Unfortunately there's no way to return a lifetime to something from a &mut self that doesn't extend the lifetime of the mutable borrow. So it's better not borrow at all here.

I think @evanlinjin tried to make this change some time ago but I NACK'd it. Now I understand why it's unavoidable. Sorry!

LLFourn avatar Feb 12 '24 23:02 LLFourn

This needs a rebase but otherwise looks good to me.

notmandatory avatar Apr 22 '24 18:04 notmandatory

@LLFourn is it OK if someone else takes this over and rebases it?

notmandatory avatar May 18 '24 02:05 notmandatory

I think it can be done in #1438

ValuedMammal avatar May 18 '24 12:05 ValuedMammal

Closing this PR as equivalent fixes are included in #1451. a5142decfcd0581bf871755b8130782666329017

notmandatory avatar Jun 04 '24 21:06 notmandatory