bdk icon indicating copy to clipboard operation
bdk copied to clipboard

[chain] keychain module doesn't need to exist

Open LLFourn opened this issue 1 year ago • 2 comments

The module tries to explain itself as follows:

A keychain here is a set of application-defined indexes for a miniscript descriptor where we can derive script pubkeys at a particular derivation index.

Which is very difficult to read. More importantly it only has one thing in it KeyChainTxOutIndex. We can just have keychain_txout_index.rs. We could move indexers into their own module so indexers/keychain_txout.rs, indexers/spk_txout.rs.

LLFourn avatar Feb 02 '24 03:02 LLFourn

Let's do this after #1203. I'll take responsibility for the convoluted crate docs.

evanlinjin avatar Feb 02 '24 07:02 evanlinjin

@evanlinjin If you want I can open a PR and have you make suggestions for the crate docs.. Actually, removing this module means we won't need the old docs. This also gives us a chance to finally relocate the Balance struct

ValuedMammal avatar Jun 22 '24 22:06 ValuedMammal