bdk icon indicating copy to clipboard operation
bdk copied to clipboard
verified publisher icon bitcoindevkit

Rename `is_coin_base` to `is_coinbase`

Open realeinherjar opened this issue 2 years ago • 2 comments

rust-bitcoin v0.31.1 has deprecated is_coin_base and renamed to is_coinbase in https://github.com/rust-bitcoin/rust-bitcoin/pull/1796.

The functionality seems the same.

We are using the deprecated one in

https://github.com/bitcoindevkit/bdk/blob/3569acca0b3f3540e1f1a2278794eac4642a05e4/crates/chain/src/tx_graph.rs#L260-L262

https://github.com/bitcoindevkit/bdk/blob/3569acca0b3f3540e1f1a2278794eac4642a05e4/crates/bdk/src/wallet/mod.rs#L1695

realeinherjar avatar Nov 01 '23 15:11 realeinherjar

Good suggestion!

notmandatory avatar Nov 13 '23 16:11 notmandatory

A small change but I think we should push to 2.0 milestone.

notmandatory avatar Mar 20 '24 02:03 notmandatory