bdk icon indicating copy to clipboard operation
bdk copied to clipboard

Use `max_weight_to_satisfy` instead of `max_satisfaction_weight`

Open danielabrozzoni opened this issue 2 years ago • 3 comments

Needs #1023

max_satisfaction_weight is deprecated, we should switch to using max_weight_to_satisfy instead.

Note that the switch is not an easy search and replace, the two methods have slightly different definitions

danielabrozzoni avatar Jul 19 '23 17:07 danielabrozzoni

@notmandatory and @danielabrozzoni I want to try to help this one out.

realeinherjar avatar Sep 09 '23 11:09 realeinherjar

We need to discuss whether this needs to go into the BDK v1.0.0 release.

If we are overshooting while using .max_weight_to_satisfy, I think it is okay to leave it as is. It will be a large change to use the new rust-bitcoin methods.

If there is a chance for undershooting, that will be high risk and we should switch to use the new API.

evanlinjin avatar Feb 05 '24 12:02 evanlinjin

@nondiremanuel assign me and unassign @realeinherjar.

storopoli avatar Mar 01 '24 12:03 storopoli