bdk-ffi

bdk-ffi copied to clipboard

The TxBuilder should go in its own module and the other 2 or 3 smaller types should go in the types module.

thunderbiscuit

Add finalize to Psbt

5

### Description Add finalize() to Psbt. See https://github.com/bitcoindevkit/bdk-ffi/issues/469 ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I...

andreasgriffin

Expose `add_global_xpubs()` method on transaction builder

1

This PR exposes the `add_global_xpubs()` method on the `TxBuilder`. See the [docs here](https://docs.rs/bdk_wallet/1.0.0-beta.1/bdk_wallet/struct.TxBuilder.html#method.add_global_xpubs). Fixes #572 ### Changelog notice ```md Added - Add `add_global_xpubs()` method on `TxBuilder` [#574] [#574]: https://github.com/bitcoindevkit/bdk-ffi/pull/574 ```...

thunderbiscuit

Title says it all. [The method](https://docs.rs/bdk_wallet/1.0.0-beta.1/bdk_wallet/struct.Wallet.html) allows you to get the highest derivation index used for a given keychain. ### Changelog notice ```md Added - Add `wallet.derivation_index` method on Wallet...

thunderbiscuit

**Describe the enhancement** BDK seems to include multipath descriptors ([rust-miniscript PR](https://github.com/rust-bitcoin/rust-miniscript/pull/470) and [bdk support](https://docs.rs/bdk_wallet/latest/bdk_wallet/descriptor/enum.Descriptor.html#method.is_multipath) ). However bdk-ffi seems to require [2 separate descriptors](https://github.com/bitcoindevkit/bdk-ffi/blob/34543311bb5d099ef0df0a358e32c4ad80f9e4fd/bdk-ffi/src/bdk.udl#L363). Please enable, either - Wallet creation from...

andreasgriffin

In both clients our current function takes a first argument called `full_scan_request`, when in fact on the Rust side [it's simply called `request`](https://docs.rs/bdk_electrum/latest/bdk_electrum/struct.BdkElectrumClient.html#method.full_scan).

thunderbiscuit

Just keeping track and pushing changes here so others can pick them up.

thunderbiscuit

This PR allows our library to depend on an external [bitcoin-ffi](https://github.com/thunderbiscuit/rust-bitcoin-ffi) library. This is useful because it means we can collaborate with other projects who also need to use types...

thunderbiscuit

**Describe the enhancement** Please expose `add_global_xpubs` from https://github.com/bitcoindevkit/bdk/blob/d99b3ef4b449a5c7b8facf04db3cb9be829a0ac1/crates/wallet/src/wallet/tx_builder.rs#L530 **Use case** Some hardware wallets, need the xpubs field filled (e.g. [bitbox02](https://github.com/bitcoin-core/HWI/blob/9fbe6beb63d9a3be68aec084fd9ac0bef4756119/hwilib/devices/bitbox02.py#L623) ) to be able to sign multisig psbts.

andreasgriffin

**Describe the bug** bdkFFI.framework/bdkFFI does not contain a slice for arm64e-apple-macosx21.1 **Build environment** - BDK tag/commit: 1.0.0-alpha.11 - OS+version: macOS 15 beta - Rust/Cargo version: 1.77 - Rust/Cargo target: arm64-apple-darwin...

nieaowei