bdk-ffi icon indicating copy to clipboard operation
bdk-ffi copied to clipboard

Ci/apply zizmor security audit

Open aagbotemi opened this issue 8 months ago • 1 comments

Description

This PR fixes #638. It fixes persist credentials and template injection (environment variable was used).

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • [x] I've signed all my commits
  • [x] I followed the contribution guidelines
  • [x] I'm linking the issue being fixed by this PR

aagbotemi avatar Apr 02 '25 20:04 aagbotemi

This PR has been signed and rebased. Similar fix has been done in bdk. Thanks.

aagbotemi avatar Apr 15 '25 02:04 aagbotemi

Just a quick update: I'll wait for https://github.com/bitcoindevkit/bdk_wallet/pull/8 to get merged before looking at this.

thunderbiscuit avatar May 06 '25 12:05 thunderbiscuit

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@aagbotemi great job! if you can just rebase this once more I will merge it

Thank you @reez, I have rebased

aagbotemi avatar Jun 11 '25 18:06 aagbotemi