bdk-ffi icon indicating copy to clipboard operation
bdk-ffi copied to clipboard

Set name of Swift module in uniffi.toml

Open thunderbiscuit opened this issue 1 year ago • 1 comments

You can add the module_name field to the uniffi.toml file to name the module correctly from the get go instead of building the default one (bdk.swift) and then renaming it in our shell build file. See all config options for Swift here.

Note that fixing this requires adding to the uniffi.toml file:

[bindings.swift]
cdylib_name = "bdkffi"
module_name = "BitcoinDevKit"

But also fixing the build-local-swift.sh file as well as the CI workflow on the bdk-swift repo.

  • [ ] uniffi.toml
  • [ ] build-local-swift.sh
  • [ ] publish-spm.yaml on bdk-swift repository

thunderbiscuit avatar Jun 05 '24 02:06 thunderbiscuit

This might need changes in other places too: we have some files that define metadata for the library that use the bdkFFI string (which then becomes BitcoinDevKitFFI), and the new library headers and umbrella.h and module.modulemap all include it. So not sure if the change in that metadata would have a bigger impact than I initially imaged.

thunderbiscuit avatar Jun 05 '24 10:06 thunderbiscuit

Done!

thunderbiscuit avatar Mar 28 '25 18:03 thunderbiscuit