bitcoin

bitcoin copied to clipboard

build: add test_bitcoin.exe to win installer, don't install entire docs/ dir

2

Haven't tested other than checking that it Guix builds. Fixes: #17171. Guix build (x86_64): ```bash 6e2886c80eba9c829047c04586b142d5f8f1c53c31aa82834aff39ae5dbf1762 guix-build-d755ffc3277c/output/dist-archive/bitcoin-d755ffc3277c.tar.gz cdf727c45c3283523726b4ec27f051de5931469874af736eac05d48016d6369b guix-build-d755ffc3277c/output/x86_64-w64-mingw32/SHA256SUMS.part 546866b2f0c8067c168a936246c4cda25745c1b484322201230b885511f2abd7 guix-build-d755ffc3277c/output/x86_64-w64-mingw32/bitcoin-d755ffc3277c-win64-debug.zip 31dbb780dff003089d0e9a3a2598cde89453af4f1b18e392a186a6ec14718b48 guix-build-d755ffc3277c/output/x86_64-w64-mingw32/bitcoin-d755ffc3277c-win64-setup-unsigned.exe 39f1c55a2426390f014282d0a736ceb77e461199fde6ccefcef53ecf10dc4960 guix-build-d755ffc3277c/output/x86_64-w64-mingw32/bitcoin-d755ffc3277c-win64-unsigned.tar.gz 7e4f7dc3475598d187e77cc31842ad2ce876fb98dc42e999b32bdefbf0b79df1 guix-build-d755ffc3277c/output/x86_64-w64-mingw32/bitcoin-d755ffc3277c-win64.zip ```

fanquake

util, config: error on startup if `conf` or `reindex` are set in config file

7

In help from `bitcoind -h` it specifes that `conf` can only be used from the commandline. However, if `conf` is set in a `bitcoin.conf` file, there is no error and...

josibake

rpc: add ability to export/import descriptor files in `listdescriptors` and `importdescriptors`

8

This PR adds a new parameter `save_to_file` to `listdescriptors` RPC, allowing the user to save the descriptors directly to a file and also adds a new parameter `desriptor_file` to `importdescriptors`...

w0xlt

refactor: Drop `boost/algorithm/string/replace.hpp` dependency

2

A new implementation of the `ReplaceAll()` seems enough for all of our purposes.

hebasto

build: Add -fvisibility=hidden flag for macOS host

16

On master (a213bd63ca0c96e8c98e84ec916f83c4ba28d486) when building `bitcoin-qt` with depends for macOS, clang spams with a load of warnings like this one: ``` ld: warning: direct access in function 'QMetaTypeIdQObject::qt_metatype_id()' from file...

hebasto

build: Add CMake-based build system

96

Here are some benefits of using [CMake](https://cmake.org/) in the Bitcoin Core project: - an opportunity to drop the `build_msvc` subdirectory from the repo altogether (being a cross-platform tool, CMake is...

hebasto

rest: Further API and code cleanup with query parameters

4

## Introduction In RESTful APIs, path parameters (e.g. `/some/unique/resource/`) are [typically](https://rapidapi.com/blog/api-glossary/parameters/query/) used to represent resources, and query parameters (e.g. `?sort=asc`) are used to control how these resources are being loaded...

stickies-v

scripted-diff: test: rename `MAX_{ANCESTORS,DESCENDANTS}` to `DEFAULT_{ANCESTOR,DESCENDANT}_LIMIT`

1

This PR renames the default in-mempool max ancestors/descendants constants `MAX_ANCESTORS`/`MAX_DESCENDANTS` in the functional tests to match the ones in the codebase: https://github.com/bitcoin/bitcoin/blob/c012875b9ded0a5183602f002738ca823d559518/src/policy/policy.h#L58-L59 https://github.com/bitcoin/bitcoin/blob/c012875b9ded0a5183602f002738ca823d559518/src/policy/policy.h#L62-L63 The custom limit constants `MAX_ANCESTORS_CUSTOM`/`MAX_DESCENDANTS_CUSTOM` are also...

theStack

`scriptpubkey` is not a clear error message. This PR changes it to `non-standard-scriptpubkey`, indicating the reason for the error.

w0xlt

wallet: simplify ListCoins implementation

5

Focused on the following changes: 1) Removed the entire locked coins lookup inside `ListCoins` by including them directly on the `AvailableCoins` result (where we were skipping them before). 2) Grouped...

furszy