doc: better document NetEventsInterface and the deletion of "CNode"s
Document the requirements around the NetEventsInterface's methods and the lifetime of CNode objects in CConnman::m_nodes.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32278.
Reviews
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| Stale ACK | w0xlt |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Conflicts
No conflicts as of last run.
LLM Linter (✨ experimental)
Possible typos and grammar issues:
- no-referenced -> unreferenced [“no-referenced” is not a valid adjective; use “unreferenced” (or “no longer referenced”) to convey that the CNode has no references]
drahtbot_id_5_m
1091faf8ff...0f26ac35e2 and 0f26ac35e2...e44e669378: further elaborate how we safely access CNodes in m_nodes and how we avoid CNode destruction while it is being referenced.
e44e669378...110548c9ea: take suggestions