bitcoin icon indicating copy to clipboard operation
bitcoin copied to clipboard

Published 20 hours ago • verified publisher icon bitcoin

[refactor] Cleanup BlockAssembler mempool usage

Open TheCharlatan opened this issue 1 year ago • 5 comments

The addPackageTxs method of the BlockAssembler currently has access to two mempool variables, as an argument and as a member. Clean this up and clarify that they both are the same mempool instance by removing the argument and instead only using the member variable in the method.

This was noticed in this PR review: https://github.com/bitcoin/bitcoin/pull/25223#discussion_r898164322.

TheCharlatan avatar Nov 10 '23 11:11 TheCharlatan