bips icon indicating copy to clipboard operation
bips copied to clipboard

[trivial]: Correct spellings across bips

Open Varunram opened this issue 6 years ago • 12 comments

Varunram avatar Apr 14 '18 05:04 Varunram

ACK 333a605d21c77002efb27aaf2fe352775f1bb3b0

practicalswift avatar May 10 '18 09:05 practicalswift

BIP 35: @jgarzik BIP 60: @genjix ~~BIPs 11, 16, 61: @gavinandresen~~ BIPs 80 & 81: @justusranvier @jimmysong ~~BIPs 98, 116, 117: @maaku @kallewoof @btcdrak~~ ~~BIP 143: @jl2012 @sipa~~ BIP 152: @TheBlueMatt ~~BIP 157: @Roasbeef @aakselrod @jimpo~~ BIP 158: @Roasbeef @aakselrod BIP 174: @achow101 BIP 176: @jimmysong

@practicalswift Why did you ACK this? You don't seem to be an author for any of the BIPs? O.o

luke-jr avatar May 20 '18 08:05 luke-jr

@luke-jr I wasn't aware that only BIP authors were supposed to review typo fixes. Sorry about that! :-)

practicalswift avatar May 20 '18 08:05 practicalswift

Yes, it's kind of a nuisance. I opened #596 a while back, but got push-back on the mailing list. :(

luke-jr avatar May 20 '18 09:05 luke-jr

ACK BIP 157

jimpo avatar May 20 '18 18:05 jimpo

ACK BIP 143

sipa avatar May 20 '18 19:05 sipa

ACK BIP 98, 116, 117.

kallewoof avatar May 20 '18 23:05 kallewoof

Perpetual ACK for all trivial changes that do not change the meaning of BIPs I wrote.

gavinandresen avatar May 21 '18 11:05 gavinandresen

ping @luke-jr, can I edit the PR just to include the BIPs which have been ACKed?

Varunram avatar Jun 20 '18 05:06 Varunram

Please don't. That would reset the ACKs. I'll manually merge the applicable ones when I get a chance.

luke-jr avatar Jun 20 '18 06:06 luke-jr

Merged BIPs 11, 16, 61, 98, 116, 117, 143, 157 in c3e8379b611a53114544b0ed7af5307b022b8ac8

Leaving open for the remaining BIPs (please don't rebase)

luke-jr avatar Jul 05 '18 05:07 luke-jr

ACK, for my small part

jgarzik avatar Feb 16 '24 14:02 jgarzik

I made a mistake in resolving the merge conflict with BIP-0176 and had to revert the change in another commit to avoid force pushing. I squashed the remaining for typos into master.

murchandamus avatar Apr 30 '24 18:04 murchandamus