bips icon indicating copy to clipboard operation
bips copied to clipboard

Published 20 hours ago • verified publisher icon bitcoin

BIP 143: Unify coin unit

Open azuchi opened this issue 8 years ago • 2 comments

In the example of BIP 143, the unit of coin output only 'No FindAndDelete' is described with satoshi. so changed it to the value of BTC unit according to other examples.

scriptPubKey : 00209e1be07558ea5cc8e02ed1d80c0911048afad949affa36d5c3951e3159dbea19, value: 200000

change to

scriptPubKey : 00209e1be07558ea5cc8e02ed1d80c0911048afad949affa36d5c3951e3159dbea19, value: 0.00200000

azuchi avatar Feb 19 '17 07:02 azuchi

@jl2012 @sipa

(IMO it should be the other way around, since we're dealing with low-level stuff here)

luke-jr avatar Feb 19 '17 09:02 luke-jr

I agree with @luke-jr – using values denominated in satoshi would make more sense in this context.

jonathancross avatar Nov 06 '17 19:11 jonathancross

@sipa: It seems reasonable that the amounts should either be BTC or sats across the document. What do you think?

murchandamus avatar Apr 23 '24 18:04 murchandamus

ACK b2b24b53935544f45188fbe1ae8701074b8cc9f6

The current document uses amounts inconsistently, and this change makes it consistent. While I agree that using sats throughout would be even better, that shouldn't hold up this improvement. The specified hex inputs to the hash function in the examples are (obviously) in sats, so I don't think it's too bad.

sipa avatar Apr 23 '24 18:04 sipa