bips icon indicating copy to clipboard operation
bips copied to clipboard

Mention explicitly that CTV does not commit to inputs

Open OrfeasLitos opened this issue 2 years ago • 6 comments

OrfeasLitos avatar Jul 10 '23 21:07 OrfeasLitos

@JeremyRubin

luke-jr avatar Jul 18 '23 00:07 luke-jr

Leaning towards nack, there's an infinitude of things not committed to, it's better to read the spec of what is comitted.

On Mon, Jul 17, 2023, 8:40 PM Luke Dashjr @.***> wrote:

@JeremyRubin https://github.com/JeremyRubin

— Reply to this email directly, view it on GitHub https://github.com/bitcoin/bips/pull/1475#issuecomment-1639103997, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGYN63VLF6X3WU6B2TIEFDXQXLOXANCNFSM6AAAAAA2FD66ME . You are receiving this because you were mentioned.Message ID: @.***>

JeremyRubin avatar Jul 18 '23 06:07 JeremyRubin

CTV is a template (as opposed to a full specification) precisely because it doesn't commit to the inputs. Input omission is one of the central design drivers of CTV, IIUC.

This change adds crucial intermediate-level intuition, which now the reader can only glean by a tedious process of elimination.

OrfeasLitos avatar Jul 18 '23 09:07 OrfeasLitos

The BIP currently has this text:

The set of data committed to is a superset of data which can impact the TXID of the transaction, other than the inputs.

JeremyRubin avatar Jul 26 '23 19:07 JeremyRubin

It's tucked away halfway through the document though, after the specification. Also IMO this particular phrasing and the surrounding text does not highlight enough why leaving inputs out is one of the keys to CTV.

If there is an intention for the BIP to be readable by folks with less than full Bitcoin expertise, this central design choice should be mentioned together with other central design decisions, early on and clearly, not relegated with other implementation details.

I believe that making this technical document more accessible to a wider audience with little touches like the one proposed here will attract more supporters and help to expedite CTV adoption.

OrfeasLitos avatar Jul 27 '23 09:07 OrfeasLitos

I'll defer this decision to the editing team, I don't really know who or what audience bips are ultimately for.

The change at least seems accurate to me

On Thu, Jul 27, 2023, 5:44 AM Orfeas Stefanos Thyfronitis Litos < @.***> wrote:

It's tucked away halfway through the document though, after the specification. Also IMO this particular phrasing and the surrounding text does not highlight enough why leaving inputs out is one of the keys to CTV.

If there is an intention for the BIP to be readable by folks with less than full Bitcoin expertise, this central design choice should be mentioned together with other central design decisions, early on and clearly, not relegated with other implementation details.

I believe that making this technical document more accessible to a wider audience with little touches like the one proposed here will attract more supporters and help to expedite CTV adoption.

— Reply to this email directly, view it on GitHub https://github.com/bitcoin/bips/pull/1475#issuecomment-1653270008, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGYN67ZSPK7F22ATADCDZDXSI2AHANCNFSM6AAAAAA2FD66ME . You are receiving this because you were mentioned.Message ID: @.***>

JeremyRubin avatar Jul 27 '23 14:07 JeremyRubin