bips icon indicating copy to clipboard operation
bips copied to clipboard

BIP 341: allow taproot_sign_key with no script tree

Open jonasnick opened this issue 2 years ago • 1 comments

In contrast to taproot_output_script, taproot_sign_key was not able to deal with a script_tree that is None. This commit fixes taproot_sign_key such that it can sign for such outputs.

This commit avoids changing the behavior of the functions except taproot_sign_key at the cost of having some code duplication. Alternatively, one could let taproot_tree_helper deal with a None script_tree directly.

CC @sipa @ajtowns

jonasnick avatar Aug 12 '22 08:08 jonasnick

Yeah this addresses the issue brought up in #1348 👍

Randy808 avatar Aug 12 '22 10:08 Randy808

ACK 3b6b398e7723e501939fac993d6ca5ca72f89975

sipa avatar Nov 10 '22 18:11 sipa

Conflicts.

kallewoof avatar Jan 04 '23 02:01 kallewoof

rebased

jonasnick avatar Jan 04 '23 14:01 jonasnick