bips icon indicating copy to clipboard operation
bips copied to clipboard

Remove newline to fix list rendering

Open tcharding opened this issue 4 years ago • 1 comments

Currently the newline in list items in BIP-0158 is causing the text on the new line to be rendered as a code section. I am unsure why this is happening but putting all the text for each list item on a single line fixes it.

tcharding avatar Aug 17 '21 08:08 tcharding

Verified that the display issue exists and that the patch fixes rendering. I tested removing the whitespace after the newline but preserving the newline itself to see if that helped but it did not, so the suggested solution seems reasonable to me.

Minor nit if you're up for ACKing, @Roasbeef and/or @aakselrod

kallewoof avatar Aug 17 '21 10:08 kallewoof

Friendly bump - I went to read the BIP again today, saw the issue, went to fix it, and realized I fixed it years ago :)

tcharding avatar Jan 23 '23 00:01 tcharding

This looks good to me. :+1:

aakselrod avatar Feb 13 '23 18:02 aakselrod